[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RE: [8u] RFR JDK-8161144: Fix for JDK-8147451 failed: Crash in Method::checked_resolve_jmethod_id(_j
From:       Shafi Ahmad <shafi.s.ahmad () oracle ! com>
Date:       2016-07-29 15:10:16
Message-ID: 1c8198e3-0080-4f52-aa24-ef44751d7e71 () default
[Download RAW message or body]

Hi All,

Could I have 2nd Reviewer's review for this change, please?

Regards,
Shafi

> -----Original Message-----
> From: Coleen Phillimore
> Sent: Monday, July 25, 2016 5:52 PM
> To: hotspot-runtime-dev@openjdk.java.net
> Subject: Re: [8u] RFR JDK-8161144: Fix for JDK-8147451 failed: Crash in
> Method::checked_resolve_jmethod_id(_jmethodID*)
> 
> 
> This looks good.  Was this a backport or is it still broken in 9?
> thanks,
> Coleen
> 
> On 7/25/16 7:53 AM, Shafi Ahmad wrote:
> > Hi,
> >
> > Please review the small code change for bug: "JDK-8161144: Fix for JDK-
> 8147451 failed: Crash in
> Method::checked_resolve_jmethod_id(_jmethodID*)" on jdk8u-dev
> >
> > Summary:
> > Method::deallocate_contents() should clear 'this' from list of Methods in
> JNIMethodBlock, similarly to clear_all_methods() does it, when class is
> unloaded.
> > After this change I am seeing Method::is_method_id() is getting called with
> NULL and I have done below change to avoid crash
> >
> > -  assert(m != NULL, "should be called with non-null method");
> > +  if (m == NULL) {
> > +    return false;
> > +  }
> >
> > Webrev: http://cr.openjdk.java.net/~shshahma/8161144/webrev/
> > Jdk8 bug: https://bugs.openjdk.java.net/browse/JDK-8161144
> >
> > Test:  Run jprt
> >
> > Regards,
> > Shafi
> 
[prev in list] [next in list] [prev in thread] [next in thread]