[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RE: [8u] RFR for JDK-8158373: SIGSEGV: Metadata::mark_on_stack
From:       Shafi Ahmad <shafi.s.ahmad () oracle ! com>
Date:       2016-06-21 6:01:15
Message-ID: 4f92c8a8-199b-4334-aff8-7501668c85f0 () default
[Download RAW message or body]

Thanks Coleen and Serguei.

Regards,
Shafi

> -----Original Message-----
> From: Serguei Spitsyn
> Sent: Monday, June 20, 2016 11:56 PM
> To: Coleen Phillimore; Shafi Ahmad; hotspot-runtime-dev@openjdk.java.net
> Subject: Re: [8u] RFR for JDK-8158373: SIGSEGV: Metadata::mark_on_stack
> 
> +1
> 
> Thanks!
> Serguei
> 
> 
> On 6/20/16 10:19, Coleen Phillimore wrote:
> >
> > This looks good.  Thank you for fixing it!
> > Coleen
> >
> > On 6/20/16 6:25 AM, Shafi Ahmad wrote:
> >> Hi ,
> >>
> >> Please review the code change for "JDK-8158373: SIGSEGV:
> >> Metadata::mark_on_stack" to jdk8u.
> >>
> >> Summary:
> >> In jdk8, MetadataOnStackMark is run in clean_metaspaces() rather than
> >> in ClassLoaderDataGraph::do_unloading(), so calling
> >> free_deallocate_list() without first marking is not safe.
> >> Current code change move the call of free_deallocate_list() inside
> >> function free_deallocate_lists() which is called from
> >> clean_metaspaces().
> >>
> >> Jdk8 Bug: https://bugs.openjdk.java.net/browse/JDK-8158373
> >> Webrev link: http://cr.openjdk.java.net/~shshahma/8158373/webrev.00/
> >>
> >> Testing: jprt and failed tests
> >>
> >> Regards,
> >> Shafi
> >>
> >>
> >
> 
[prev in list] [next in list] [prev in thread] [next in thread]