[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8157133: CompactHashtableWriter SIGFPE when num bucket is zero
From:       Dmitry Samersoff <dmitry.samersoff () oracle ! com>
Date:       2016-06-16 8:03:57
Message-ID: 38d033b4-5be5-c119-9890-ec1d9bffe98d () oracle ! com
[Download RAW message or body]

Robbin,

OK.  Sorry for being later with the review.

-Dmitry

On 2016-06-16 10:36, Robbin Ehn wrote:
> Hi Dmitry,
> 
> This change have already been pushed in hg revision 11272.
> 
> Sorry for the confusion and thanks reviewing!
> 
> The case I created was for verifying that the calculations are as
> intended. (this is a bit unclear)
> 
> My thought was whoever does that can also address your concern with the
> division, since I already pushed this.
> 
> Thanks!
> 
> /Robbin
> 
> 
> On 06/16/2016 09:21 AM, Dmitry Samersoff wrote:
>> Robbin,
>>
>> 1. You are listed as a reporter, but not as an assignee of the CR.
>> Please fix it.
>>
>> 2. This is comments to your fix not to the problem it self. Not sure we
>> should put review comments to the CR.
>>
>> -Dmitry
>>
>>
>> On 2016-06-16 10:09, Robbin Ehn wrote:
>>> Hi Dmitry,
>>>
>>> There is a bug for this calculation:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8157557
>>>
>>> Please comment your concerns there.
>>>
>>> /Robbin
>>>
>>>
>>> On 06/15/2016 03:26 PM, Dmitry Samersoff wrote:
>>>> Robbin,
>>>>
>>>> It might be better to refactor the code a bit, to avoid unnecessary
>>>> division:
>>>>
>>>> int number_of_entrises = the_table()->number_of_entries();
>>>> int num_buckets =
>>>>           (number_of_entries > SharedSymbolTableBucketSize) ?
>>>>           number_of_entries/SharedSymbolTableBucketSize : 1;
>>>>
>>>> -Dmitry
>>>>
>>>> On 2016-05-17 16:43, Robbin Ehn wrote:
>>>>> Hi all,
>>>>>
>>>>> Please review!
>>>>>
>>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157133
>>>>> Webrev: http://cr.openjdk.java.net/~rehn/8157133/webrev/
>>>>>
>>>>> Tested with hotspot_jprt and
>>>>> hotspot/test/runtime/CommandLine/OptionsValidation/
>>>>>
>>>>> Thanks!
>>>>>
>>>>> /Robbin
>>
> 


-- 
Dmitry Samersoff
Oracle Java development team, Saint Petersburg, Russia
* I would love to change the world, but they won't give me the sources.
[prev in list] [next in list] [prev in thread] [next in thread]