[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8153394: Add Unified Logging to make it easy to trace time taken in initPhase2
From:       Rachel Protacio <rachel.protacio () oracle ! com>
Date:       2016-06-15 15:10:42
Message-ID: 2acad1c8-9bc8-9898-2a6b-eabe9cd06bb6 () oracle ! com
[Download RAW message or body]

Thank you, Max!

Rachel


On 6/15/2016 10:42 AM, Max Ockner wrote:
> Rachel, looks good to me.
> Max
> On 6/15/2016 10:24 AM, Rachel Protacio wrote:
>> Thank you, Harold!
>>
>> Rachel
>>
>>
>> On 6/15/2016 10:21 AM, harold seigel wrote:
>>> Hi Rachel,
>>>
>>> The change looks good!
>>>
>>> Thanks, Harold
>>>
>>>
>>> On 6/14/2016 4:50 PM, Rachel Protacio wrote:
>>>> Hello!
>>>>
>>>> Please review this small change, adding unified logging for Phase2 
>>>> initialization, using the TraceTime class. (A jigsaw enhancement, 
>>>> which is why it's going in after FC.)
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8153394
>>>> Open webrev: http://cr.openjdk.java.net/~rprotacio/8153394.00/
>>>>
>>>> Output sample:
>>>>
>>>>    $ java -Xlog:startuptime+modules -version
>>>>    [0.410s][info][modules,startuptime] Phase2 initialization, 
>>>> 0.1302802
>>>>    secs
>>>>    java version "9-internal"
>>>>    Java(TM) SE Runtime Environment (fastdebug build
>>>>    9-internal+0-2016-06-09-092114.rprotaci.8153394)
>>>>    Java HotSpot(TM) 64-Bit Server VM (fastdebug build
>>>>    9-internal+0-2016-06-09-092114.rprotaci.8153394, mixed mode)
>>>>
>>>> Includes added conditions to logging/StartupTimeTest.java. Passes 
>>>> JPRT.
>>>>
>>>> Thanks,
>>>> Rachel
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]