[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8157831: JVMCI tests should not be executed on linux-arm32
From:       David Holmes <david.holmes () oracle ! com>
Date:       2016-05-31 1:26:23
Message-ID: a346027c-5f9b-4b82-b6f3-9b8657902759 () oracle ! com
[Download RAW message or body]

Hi Leonid,

This really strikes me as as a jtreg problem that should be fixed in 
jtreg. When writing an @requires clause in a test the test writer should 
not have to be thinking "oh wait! Is this going to query the VM running 
jtreg or the VM running the test?". It should obviously be the VM 
running the test.

That said we also seem to have a problem with the definition of os.arch:

os.arch 	Operating system architecture

if it is returning the build architecture of the VM and not the OS it is 
running on. That in itself argues for two distinct properties.

David

On 26/05/2016 11:45 PM, Leonid Mesnik wrote:
> Hi
>
> Could you please review following fix:
> root http://cr.openjdk.java.net/~lmesnik/8157831/webrev.00/root/
> <http://cr.openjdk.java.net/%7Elmesnik/8157831/webrev.00/root/>
> hotspot http://cr.openjdk.java.net/~lmesnik/8157831/webrev.00/hotspot/
> <http://cr.openjdk.java.net/%7Elmesnik/8157831/webrev.00/hotspot/>
> for bug
> https://bugs.openjdk.java.net/browse/JDK-8157831
> <https://bugs.openjdk.java.net/browse/JDK-8157831>
>
> The property "os.name" which was used to filter tests depends on the
> arch of jdk which is used to run jtreg. It might differ from arch of
> tested jdk.
> This fix introduce new property "vm.arch" which depends on the arch of
> tested jdk and could be used to filter tests with @requires.
>
> I verified that tests are filtered where it is expected.
> Note: I am going to push this fix in jdk9/hs to fix regular hotspot
> testing.
>
> Leonid
>
[prev in list] [next in list] [prev in thread] [next in thread]