[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8157097 (was 8157133): CompactHashtableWriter SIGFPE when num bucket is zero
From:       Robbin Ehn <robbin.ehn () oracle ! com>
Date:       2016-05-23 7:21:47
Message-ID: 72c283c6-00d0-8900-902a-640f14ced519 () oracle ! com
[Download RAW message or body]

Hi David,

On 05/23/2016 09:17 AM, David Holmes wrote:
> Hi Robbin,
>
> This seems okay as an immediate fix for the test problem.

Thanks!

>
> But I'm not completely clear on the bucket calculation logic as it seems
> we will put nearly 2x the number of entries in the first bucket. So
> please file a follow up bug for that - or discuss with someone more
> knowledgeable about the code to see if it is an issue or not.

Will do!

/Robbin

>
> Thanks,
> David
>
>> Hi Jiangli,
>>
>> Sorry for not spotting the dup.
>>
>> On 05/17/2016 06:16 PM, Jiangli Zhou wrote:
>>> Hi Robbin,
>>>
>>> Looks good. Thanks for fixing this!
>>
>> Thanks!
>>
>> So this goes on 8157097 instead!
>>
>> /Robbin
>>
>>>
>>> Thanks,
>>> Jiangli
>>>
>>>> On May 17, 2016, at 6:43 AM, Robbin Ehn <robbin.ehn at oracle.com>
>>>> wrote:
>>>>
>>>> Hi all,
>>>>
>>>> Please review!
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8157133
>>>> Webrev: http://cr.openjdk.java.net/~rehn/8157133/webrev/
>>>>
>>>> Tested with hotspot_jprt and
>>>> hotspot/test/runtime/CommandLine/OptionsValidation/
>>>>
>>>> Thanks!
>>>>
>>>> /Robbin
>>>
>
[prev in list] [next in list] [prev in thread] [next in thread]