[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RE: RFR(S): 8156922: [ppc] Implement template interpreter stack overflow checks as on x86/sparc.
From:       "Lindenmaier, Goetz" <goetz.lindenmaier () sap ! com>
Date:       2016-05-23 6:33:57
Message-ID: 6f509521a62640479cbd5d5c1029736d () DEWDFE13DE09 ! global ! corp ! sap
[Download RAW message or body]

HI Dean, 

> OK, looking at just your change, I had the following comments.  Overall, the
> changes look reasonable
> to me, for pcc.  But it seems that after this change, _stack_overflow_limit is
> only used by ppc.
> - Do you think it should be made a cpu-specific field?  Or do you think
> x86/sparc should use it as well?
Yes, as it saves a lot of instructions.  This could be done in a follow up change.
> - Do you think its value should be updated when the yellow/reserved zones
> are unprotected? 
Yes, but this should only be done after the above change has been applied
to all platforms.

Best regards,
  Goetz.

[prev in list] [next in list] [prev in thread] [next in thread]