[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8154719: JvmtiBreakpoint rename method print() to print_on()
From:       Robbin Ehn <robbin.ehn () oracle ! com>
Date:       2016-04-26 19:47:05
Message-ID: 71598589-23d1-e3b5-59f9-a29a5e5c6c41 () oracle ! com
[Download RAW message or body]

Thanks Coleen!

/Robbin

On 04/26/2016 04:28 PM, Coleen Phillimore wrote:
> Agree, looks good.  Thank you for making this change.
> Coleen
>
> On 4/26/16 4:49 AM, Robbin Ehn wrote:
>> Hi Serguei,
>>
>> Thanks!
>>
>> /Robbin
>>
>> On 04/26/2016 10:48 AM, serguei.spitsyn@oracle.com wrote:
>>> Hi Robin,
>>>
>>> Looks good.
>>>
>>> Thanks,
>>> Serguei
>>>
>>>
>>> On 4/20/16 04:47, Robbin Ehn wrote:
>>>> Hi all, please review!
>>>>
>>>> print() method was changed in 8154041 to have outputStream argument,
>>>> this renames print to print_on.
>>>> Since JvmtiBreakpoint extends GrowableElement print_on already exists
>>>> as a virtual const method, hence the const changes.
>>>>
>>>> Bug: https://bugs.openjdk.java.net/browse/JDK-8154719
>>>> Webrev: http://cr.openjdk.java.net/~rehn/8154719/webrev/
>>>>
>>>> Tested with:
>>>>
>>>> #define TraceJVMTICalls false
>>>> in hotspot/src/share/vm/prims/jvmtiEnv.cpp
>>>> set to true with test-set nsk.jvmti.SetBreakpoint
>>>>
>>>> Thanks!
>>>>
>>>> /Robbin
>>>
>

[prev in list] [next in list] [prev in thread] [next in thread]