[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: JDK-8147634 - Need a JImage API that given a JImageLocationRef returns class name
From:       harold seigel <harold.seigel () oracle ! com>
Date:       2016-04-22 13:54:16
Message-ID: 571A2D08.9020100 () oracle ! com
[Download RAW message or body]

Having a range check would be good at least until the switch to using 
indices.

Thanks, Harold

On 4/22/2016 9:38 AM, Jim Laskey (Oracle) wrote:
> Not reliably.  I can do a range check but I can’t test that the offset is correct \
> (preceeding zero byte isn’t sufficient.)  The alternative is to switch to using \
> indices instead of offsets for JImageLocationRef (as I mentioned should have ben \
> done.)  Take a bit of fiddling at this point, but doable.  One would assume that \
> you would guarantee on the result (shut down the vm), since that would mean a fail \
> of the verification data (same as if jimage were invalid.) 
> — Jim
> 
> 
> > On Apr 22, 2016, at 10:21 AM, harold seigel <harold.seigel@oracle.com> wrote:
> > 
> > Hi Jim,
> > 
> > Can you change JIMAGE_ResourcePath() to return a bad status if it is called with \
> > bogus input, such as a bad value for the JImageLocationRef? 
> > Thanks, Harold
> > 
> > On 4/22/2016 9:12 AM, Jim Laskey (Oracle) wrote:
> > > Implemented as requested by the runtime team.
> > > 
> > > http://cr.openjdk.java.net/~jlaskey/8147634/webrev/index.html \
> > > <http://cr.openjdk.java.net/~jlaskey/8147634/webrev/index.html> \
> > > https://bugs.openjdk.java.net/browse/JDK-8147634 \
> > > <https://bugs.openjdk.java.net/browse/JDK-8147634> 


[prev in list] [next in list] [prev in thread] [next in thread]