[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RE: RFR (S): 8136766: Enable ThreadStackSize range test
From:       Ron Durbin <ron.durbin () oracle ! com>
Date:       2016-03-30 20:08:12
Message-ID: da3ea6be-5bf4-42f8-972f-495dcc3c1f6e () default
[Download RAW message or body]


Gerard,

Per our phone conversation, your solution needs refactoring.
Specifically the minimum stack size mechanism you propose is not
not needed as one exists in the current implementation which I am fixing.

I have related your bug 8136766 to mine 8140520.

Ron
>-----Original Message-----
>From: Ron Durbin
>Sent: Tuesday, March 29, 2016 11:58 AM
>To: Gerard Ziemski; hotspot-runtime-dev@openjdk.java.net
>Subject: RE: RFR (S): 8136766: Enable ThreadStackSize range test
>
>Gerard,
>
>I have run the Options Range Test dozens of times with only the Max test d=
isabled for ThreadStackSize.
>I have not seen this failure of the min test on windows.  I would like to =
understand why this change is
>needed.
>
>Ron
>
>>-----Original Message-----
>>From: Gerard Ziemski
>>Sent: Friday, March 25, 2016 10:27 AM
>>To: hotspot-runtime-dev@openjdk.java.net
>>Subject: RFR (S): 8136766: Enable ThreadStackSize range test
>>
>>hi all,
>>
>>Please review this small fix which fixes the range (in platform dependent=
 way where 0 has a special meaning on
>>Windows) and adds constraint for ThreadStackSize, which allows us to incl=
ude it in
>>test/runtime/CommandLine/OptionsValidation/TestOptionsWithRanges.java tes=
t.
>>
>>https://bugs.openjdk.java.net/browse/JDK-8136766
>>http://cr.openjdk.java.net/~gziemski/8136766_rev1
>>
>>Passes JPRT hotspot and RBT CommandLine/OptionsValidation/TestOptionsWith=
Ranges on all platforms.
[prev in list] [next in list] [prev in thread] [next in thread]