[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    [Closed] RFR (XS) 8152380 - Shared symbol/string tables should never use alternate hashcode
From:       Ioi Lam <ioi.lam () oracle ! com>
Date:       2016-03-25 4:05:51
Message-ID: 56F4B91F.6040509 () oracle ! com
[Download RAW message or body]

Here are the closed changes:

http://ioilinux.us.oracle.com/webrev/jdk9/jdk9/8152380_shared_table_rehashing.v02/

New tests to force alternate hashing for strings and symbols:
       runtime/7158800/BadUtf8_Shared.java
       runtime/7158800/InternTest_Shared.java

I also added a few test cases in 
runtime/AppCDS/sharedStrings/InternStringTest.java to check for correct 
hashing of different UNICODE characters.

Thanks
- Ioi

On 3/24/16 9:01 PM, Ioi Lam wrote:
> Please review a very small fix:
>
> http://cr.openjdk.java.net/~iklam/jdk9/8152380_shared_table_rehashing.v02/ 
>
>     https://bugs.openjdk.java.net/browse/JDK-8152380
>
> Summary of fix:
>
> I added a new function, SymbolTable::hash_shared_symbol(), that does not
>     use the alternate hashing algorithm.
>
>     To validate the fix, I added new test cases that force alternate 
> hashing
>     while CDS is enabled (thus we have a shared symbol/string tables).
>     Unfortunately the tests are in closed repos.
>
>     Testing showed that the problem existed only for the shared symbol 
> table.
>     The shared string table already did not use the alternate hashing 
> algorithm.
>
> Tests:
>
>     JPRT
>     RBT with hotspot tests
>
> Thanks
> - Ioi

[prev in list] [next in list] [prev in thread] [next in thread]