[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: 8147500: The HashtableTextDump::get_num() should check for integer overflow
From:       Jiangli Zhou <jiangli.zhou () oracle ! com>
Date:       2016-01-22 16:39:53
Message-ID: 2018C1BB-6DFD-4660-A796-9115CF649624 () oracle ! com
[Download RAW message or body]

Thank you, David!

> On Jan 22, 2016, at 4:22 AM, David Holmes <david.holmes@oracle.com> wrote:
> 
> PS. Don't forget copyright updates :)

Will update copyright before pushing.

Thanks!
Jiangli

> 
> On 22/01/2016 2:37 PM, David Holmes wrote:
>> Hi Jiangli,
>> 
>>> Please review the following improvements to
>>> HashtableTextDump::get_num() and HashtableTextDump::corrupted_if()
>>> described in JDK-8147500
>>> <https://bugs.openjdk.java.net/browse/JDK-8147500>.
>>> 
>>> - The HashtableTextDump::get_num() is use to parse an integer value
>>> from the input file. It should check for integer overflow and report
>>> error without continuing.
>>> - The HashtableTextDump::corrupted_if() should take an additional
>>> argument so caller can pass a meaningful error message.
>>> 
>>> Webrev: http://cr.openjdk.java.net/~jiangli/8147500/webrev.00/
>> 
>> As improvements on the existing code this seems fine.
>> 
>> Thanks,
>> David

[prev in list] [next in list] [prev in thread] [next in thread]