[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XXS): 8144084: [TESTBUG] 1.9 section not unlock flag in runtime/CommandLine/IgnoreUnrecogniz
From:       David Holmes <david.holmes () oracle ! com>
Date:       2015-11-26 21:11:18
Message-ID: 56577576.6060407 () oracle ! com
[Download RAW message or body]

Looks good.

Thanks,
David

> Hello,
>
> Please review fix for the
> runtime/CommandLine/IgnoreUnrecognizedVMOptions test. Section 1.9
> verifies malformed unlocked flag, but actually flags are locked, because
> '-XX:-UnlockDiagnosticVMOptions' is passed instead of
> '-XX:+UnlockDiagnosticVMOptions' and '-XX:-UnlockExperimentalVMOptions'
> instead of '-XX:+UnlockExperimentalVMOptions'. I.e. test performs the
> same thing as in section 1.8.
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8144084
> webrev.00: http://cr.openjdk.java.net/~ddmitriev/8144084/webrev.00/
> <http://cr.openjdk.java.net/%7Eddmitriev/8144084/webrev.00/>
> Tested: JPRT + locally on Linux-x64 with OpenJDK build(product&debug)
>
> Thanks,
> Dmitry


[prev in list] [next in list] [prev in thread] [next in thread]