[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(S): 8143963: improve ClassLoader::trace_class_path to accept an additional outputStream* arg
From:       Calvin Cheung <calvin.cheung () oracle ! com>
Date:       2015-11-24 23:15:33
Message-ID: 5654EF95.1000506 () oracle ! com
[Download RAW message or body]

Chris, Coleen, Jiangli,

Thank you all for the quick review.

Calvin

On 11/24/15, 2:45 PM, Chris Plummer wrote:
> +1, from a "r"eviewer.
>
> Chris
>
> On 11/24/15 2:34 PM, Coleen Phillimore wrote:
>>
>> This looks good.
>> Coleen
>>
>> On 11/24/15 5:08 PM, Calvin Cheung wrote:
>>> Please review this small fix for adding more flexibility to the 
>>> ClassLoader::trace_class_path() function.
>>>
>>> This is done mainly to prevent the truncation of the trace output.
>>>
>>> JBS: https://bugs.openjdk.java.net/browse/JDK-8143963
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8143963/webrev.00/
>>>
>>> testing:
>>>     JPRT with -testset hotspot
>>>     tests under tests under hotspot/test/runtime/SharedArchiveFile/
>>>
>>> thanks,
>>> Calvin
>>
>
[prev in list] [next in list] [prev in thread] [next in thread]