[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-hotspot-runtime-dev
Subject: Re: RFR [M] : 8087333, Optionally Pre-Generate the HotSpot Template Interpreter
From: David Holmes <david.holmes () oracle ! com>
Date: 2015-06-24 9:03:41
Message-ID: 558A726D.6090500 () oracle ! com
[Download RAW message or body]
Hi Bertrand,
This all seems okay to me - thanks for your efforts here.
One nit:
src/share/vm/interpreter/interpreterRuntime.cpp
This line is rather too long :)
1191 if (UseFastSignatureHandlers &&
CodeCacheExtensions::support_fast_signature_handlers() &&
method->size_of_parameters() <= Fingerprinter::max_size_of_parameters) {
Thanks,
David
On 23/06/2015 10:02 PM, Bertrand Delsart wrote:
> Thanks David and Coleen for the comments.
>
> Updated webrev and incremental webrev taking into account your feedbacks.
>
> Summary of the small incremental changes with respect to 00:
>
> - cleaned up the %.o : %.S rule
> * THIS IS NEW *: check findsrc in linux vm.make file
>
> - avoided a potential issue with unused .S files in the
> open aarch64 port
>
> - fixed non-PCH build issue (both in my code and in other files)
>
> - misc changes suggested by David (which were in webrev.01)
>
> - misc changes suggested by Coleen (including whitespace changes that
> may look like empty diffs)
>
> http://cr.openjdk.java.net/~bdelsart/8087333/webrev.00-02/webrev/
>
> http://cr.openjdk.java.net/~bdelsart/8087333/webrev.02/webrev/
>
> Regards,
>
> Bertrand.
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic