[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (XS) 8064335: Null pointer dereference in hotspot/src/share/vm/classfile/verifier.cpp
From:       harold seigel <harold.seigel () oracle ! com>
Date:       2014-12-30 17:50:42
Message-ID: 54A2E5F2.20605 () oracle ! com
[Download RAW message or body]

Hi Lois, Gerard, Coleen,

Thanks for the reviews.

Harold

On 12/30/2014 10:20 AM, Coleen Phillimore wrote:
>
> Yes, this looks good.
> Coleen
>
> On 12/29/14, 3:52 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this small fix for bug 8064335.  The fix changes 
>> CHECK_VERIFY to CHECK, preventing a possible NULL value of ref_klass 
>> from being returned by load_class(), and then being fatally 
>> derefenced in the next statement.  The fix changes this call to 
>> load_class() to use CHECK, like the other verifier calls to 
>> load_class().
>>
>> Open webrev:  http://cr.openjdk.java.net/~hseigel/bug_8064335/
>>
>> JBS bug: https://bugs.openjdk.java.net/browse/JDK-8064335
>>
>> The fix was tested with JCK lang and VM tests, hotspot JTReg, and NSK 
>> split_verifier tests.
>>
>> Thanks, Harold
>

[prev in list] [next in list] [prev in thread] [next in thread]