[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XS): 8066814: Reduce accessibility in TraceEvent
From:       Staffan Larsen <staffan.larsen () oracle ! com>
Date:       2014-12-18 8:10:40
Message-ID: 93A84CDA-632F-4A58-A675-A640DE17AF00 () oracle ! com
[Download RAW message or body]

Looks good!

Thanks,
/Staffan

> On 17 dec 2014, at 15:45, Markus Grönlund <markus.gronlund@oracle.com> wrote:
> 
> Greetings,
> 
> Kindly asking for reviews for the following changeset:
> 
> Bug: https://bugs.openjdk.java.net/browse/JDK-8066814 \
>                 <https://bugs.openjdk.java.net/browse/JDK-8066814>
> Webrev: http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/ \
> <http://cr.openjdk.java.net/~mgronlun/8066814/webrev01/> 
> Description:
> TraceEvent currently exposes internals unnecessarily.
> 
> Therefore:
> 
> Remove unnecessarily exposed methods. 
> Add assert for not committing a cancelled event. 
> Add method stubs for !INCLUDE_TRACE
> 
> Thanks in advance
> Markus


[prev in list] [next in list] [prev in thread] [next in thread]