[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: 8066803: compiler/intrinsics/mathexact/SubExactINonConstantTest.java
From:       Coleen Phillimore <coleen.phillimore () oracle ! com>
Date:       2014-12-12 19:42:00
Message-ID: 548B4508.7000203 () oracle ! com
[Download RAW message or body]


On 12/12/14, 2:35 PM, Dean Long wrote:
> Looks good, but I think the Summary misleading.  It looks like we 
> would already stop when hitting
> a compiled or stub frame, due to the "fr.cb() != NULL", but we need to 
> check that before
> is_first_C_frame() to prevent the crash.

Yes, you are right, the summary is too short.  I should add that we need 
to reverse the checks, but I have one more test to run in JPRT before it 
pushes.  I will add this to the bug report though.

Thanks,
Coleen

>
>
> dl
>
> On 12/12/2014 10:05 AM, Coleen Phillimore wrote:
>>
>> Thanks!!
>> Coleen
>>
>> On 12/12/14, 1:03 PM, Christian Tornqvist wrote:
>>> This looks good, thanks for fixing this.
>>>
>>> Thanks,
>>> Christian
>>>
>>> -----Original Message-----
>>> From: hotspot-runtime-dev
>>> [mailto:hotspot-runtime-dev-bounces@openjdk.java.net] On Behalf Of 
>>> Coleen
>>> Phillimore
>>> Sent: Friday, December 12, 2014 8:34 AM
>>> To: hotspot-runtime-dev
>>> Subject: RFR: 8066803:
>>> compiler/intrinsics/mathexact/SubExactINonConstantTest.java crashed in
>>> os::is_first_C_frame(frame*)
>>>
>>> Summary: Stop native stack walk when we get to compiled or stub frame.
>>>
>>> Coming from deoptimization, we hit a compiled frame (or deopt stub
>>> actually) in native memory tracking stack walking.  This code 
>>> doesn't have
>>> the link pointer set up to match the native abi, so this crashes
>>> (sometimes).
>>>
>>> open webrev at http://cr.openjdk.java.net/~coleenp/8066803/
>>> bug link https://bugs.openjdk.java.net/browse/JDK-8066803
>>>
>>> Ran test in the bug report 700 times (crashed within 8) with the fix.
>>> Also ran NMT tests.
>>>
>>> Thanks,
>>> Coleen
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]