[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XXS): 8067015: Implement os::pd_map_memory() on AIX
From:       Alejandro E Murillo <alejandro.murillo () oracle ! com>
Date:       2014-12-10 17:43:21
Message-ID: 54888639.1040302 () oracle ! com
[Download RAW message or body]


this seems to fit the rule for an exception, so it should be fine,
although I personally prefer if it's pushed via a hotspot repo,
but this late in the week, it might not make it to jdk9/dev next week,
so go ahead and push it to jdk9/dev

Thanks,
Alejandro
On 12/10/2014 10:21 AM, Volker Simonis wrote:
> Hi Alejandro,
>
> can I push this change to jdk9/dev/hotspot?
>
> It fixes a problem which arose after the integration of the modularity
> stuff into jdk9/dev
>
> And it only touches a single AIX-only file (so no side effects on any
> other platforms)
>
> Thanks,
> Volker
>
>
> On Wed, Dec 10, 2014 at 7:29 AM, David Holmes <david.holmes@oracle.com> wrote:
>> Hi Volker,
>>
>> On 10/12/2014 3:39 AM, Volker Simonis wrote:
>>> Hi,
>>>
>>> could I please get a review for the following trivial change which
>>> simply implements os::pd_map_memory() on AIX:
>>>
>>> http://cr.openjdk.java.net/~simonis/webrevs/8067015/
>>>
>>> Until now os::pd_map_memory() was only used in the context of class
>>> data sharing (CDS) which isn't supported on AIX anyway, so we hadn't
>>> implemented it in os_aix.cpp
>>>
>>> However with the integration of the modularity change,
>>> os::pd_map_memory() is now also needed for the loading of image files.
>>>
>>> The implementation is a straightforward copy of the corresponding Linux
>>> version.
>>
>> Change looks fine to me.
>>
>>> I'd like to push this directly to jdk9/dev/hotspot because it was
>>> introduced there and because it affects all our AIX builds. I hope
>>> that's no problem, especially because the change only touches an
>>> AIX-only files.
>>
>> Need to check this with Alejandro - cc'd.
>>
>> Thanks,
>> David
>>
>>
>>> Thank you and best regards,
>>> Volker
>>>

-- 
Alejandro

[prev in list] [next in list] [prev in thread] [next in thread]