[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(M): 8022865 - [TESTBUG] Compressed Oops testing needs to be revised
From:       Vladimir Kozlov <vladimir.kozlov () oracle ! com>
Date:       2014-09-12 1:39:57
Message-ID: 54124EED.9050708 () oracle ! com
[Download RAW message or body]

I don't see updated webrev.

Vladimir

On 9/11/14 5:40 PM, Christian Tornqvist wrote:
> Thanks for the reviews, I've updated the tests to address the issues
> Vladimir pointed out.
>
> Thanks,
> Christian
>
> -----Original Message-----
> From: hotspot-runtime-dev
> [mailto:hotspot-runtime-dev-bounces@openjdk.java.net] On Behalf Of Mikhailo
> Seledtsov
> Sent: Wednesday, September 3, 2014 3:22 PM
> To: hotspot-runtime-dev@openjdk.java.net
> Subject: Re: RFR(M): 8022865 - [TESTBUG] Compressed Oops testing needs to be
> revised
>
> Hi Christian,
>
> Changes looks good to me. And thank you for adding the ability to chain
> output analyzers.
>
> Misha
>
> On 9/2/2014 5:22 PM, Vladimir Kozlov wrote:
>> UseCompressedOops.java does not have @run command. All tests are
>> missing @bug and @summary.
>>
>> Code changes looks fine.
>>
>> Thanks,
>> Vladimir
>>
>> On 8/28/14 1:42 PM, Christian Tornqvist wrote:
>>> Hi everyone,
>>>
>>>
>>>
>>> This change adds tests for the UseCompressedOops,
>>> ObjectAlignmentInBytes and CompressedClassSpaceSize flags. In order
>>> to test this I had to make some changes to the output from
>>> PrintCompressedOopsMode, refactored a bit of the code and changed the
>>> output slightly.
>>>
>>>
>>>
>>> I also made it possibly to chain OutputAnalyzer statements together
>>> by letting all the should* methods return this.
>>>
>>>
>>>
>>> Webrev:
>>>
>>> http://cr.openjdk.java.net/~ctornqvi/webrev/8022865/webrev.00/
>>>
>>>
>>>
>>> Bug:
>>>
>>> https://bugs.openjdk.java.net/browse/JDK-8022865
>>>
>>>
>>>
>>> Thanks,
>>>
>>> Christian
>>>
>
>
[prev in list] [next in list] [prev in thread] [next in thread]