[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (XXS): 8048088: Conservative maximum heap alignment should take vm_allocation_granularity in
From:       Thomas Schatzl <thomas.schatzl () oracle ! com>
Date:       2014-07-10 9:26:25
Message-ID: 1404984385.2703.10.camel () cirrus
[Download RAW message or body]

Hi Bengt,

On Mon, 2014-07-07 at 14:55 +0200, Bengt Rutisson wrote:
> On 2014-07-07 14:47, Thomas Schatzl wrote:
> > Hi all,
> >
> >    can I have reviews for the following small change? It fixes a at this
> > time benign issue when calculating the conservative maximum heap
> > alignment.
> >
> > In particular, it does not take the os::vm_allocation_granularity() into
> > account.
> > [..]
> > As it is a bug, although it is hidden by other code, and caught already
> > later too, I thought it would still be worth fixing this.
> >
> > This code touches runtime code, so I cc'ed hotspot-runtime-dev.
> >
> > Webbug:
> > http://cr.openjdk.java.net/~tschatzl/8048088/webrev/
> >
> > CR:
> > https://bugs.openjdk.java.net/browse/JDK-8048088
> 
> Looks good to me.

Thanks for the review.

Thomas


[prev in list] [next in list] [prev in thread] [next in thread]