[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XS): JDK-8040018 Remove bad assert in ClassFileParser.cpp
From:       harold seigel <harold.seigel () oracle ! com>
Date:       2014-04-18 12:40:44
Message-ID: 53511D4C.8020606 () oracle ! com
[Download RAW message or body]

Thank you Coleen!

Harold

On 4/18/2014 8:30 AM, Coleen Phillimore wrote:
>
> Looks good, Harold.
> Coleen
>
> On 4/16/14, 1:49 PM, harold seigel wrote:
>> Hi,
>>
>> Please review this small change to fix bug JDK-8040018 for JDK-9. The 
>> fix removes the assert because it can be triggered by a class file 
>> containing an incorrect attribute_length value for the 
>> BoostrapMethods attribute, not just by a JVM inconsistency. Removing 
>> the assert lets the following guarantee_property() call catch the 
>> problem and throw a java.lang.ClassFormatError exception.
>>
>> The fix was tested with JPRT, JCK lang, JCK vm, hotspot jtreg, and 
>> nsk quick tests.  The new test was tested on Linux and Windows.
>>
>> Open webrev at: http://cr.openjdk.java.net/~hseigel/bug_8040018/ 
>> <http://cr.openjdk.java.net/%7Ehseigel/bug_8040018/>
>> Bug: https://bugs.openjdk.java.net/browse/JDK-8040018
>>
>> Thanks! Harold
>

[prev in list] [next in list] [prev in thread] [next in thread]