[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-hotspot-runtime-dev
Subject: Re: RFR: 8028785: code cleanup for hotspot.src.share.vm.prims: JNI exception pending
From: Coleen Phillimore <coleen.phillimore () oracle ! com>
Date: 2014-02-12 19:03:10
Message-ID: 52FBC56E.2070107 () oracle ! com
[Download RAW message or body]
Looks good!
Coleen
On 2/12/14 1:49 PM, Calvin Cheung wrote:
> Coleen,
>
> Thanks for your review.
> I've updated the webrev with your suggestions.
> webrev: http://cr.openjdk.java.net/~ccheung/8028785/webrev/
>
> previous webrev: http://cr.openjdk.java.net/~ccheung/8028785/webrev.00/
>
> Calvin
>
> On 2/12/2014 7:39 AM, Coleen Phillimore wrote:
>>
>> This looks good. You could rename these to be consistent with CHECK
>> macros and save characters in the code.
>> thanks,
>> Coleen
>>
>> *CHECK_JNI_EXCEPTION_RETURN_VALUE
>> to
>> CHECK_JNI_EXCEPTION_() with underscore
>>
>> and
>>
>> CHECK_JNI_EXCEPTION_RETURN
>> to
>> CHECK_JNI_EXCEPTION()
>> *
>> On 2/10/14 2:56 PM, Calvin Cheung wrote:
>>> This fix is for adding JNI exception pending check in several files
>>> under src/share/vm/prims directory.
>>>
>>> bug: https://bugs.openjdk.java.net/browse/JDK-8028785 (non-open bug)
>>>
>>> webrev: http://cr.openjdk.java.net/~ccheung/8028785/webrev/
>>>
>>> Tests:
>>> jprt
>>> vm.quick (on linux-x64)
>>>
>>> Please review.
>>>
>>> thanks,
>>> Calvin
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<font size="+1">Looks good!<br>
Coleen<br>
<br>
</font>
<div class="moz-cite-prefix">On 2/12/14 1:49 PM, Calvin Cheung
wrote:<br>
</div>
<blockquote cite="mid:52FBC238.6010207@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Coleen,<br>
<br>
Thanks for your review.<br>
I've updated the webrev with your suggestions.<br>
webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eccheung/8028785/webrev/">http://cr.openjdk.java.net/~ccheung/8028785/webrev/</a><br>
<br>
previous webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eccheung/8028785/webrev.00/">http://cr.openjdk.java.net/~ccheung/8028785/webrev.00/</a><br>
<br>
Calvin<br>
<br>
On 2/12/2014 7:39 AM, Coleen Phillimore wrote:<br>
</div>
<blockquote cite="mid:52FB959C.7020809@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<br>
<font size="+1">This looks good. You could rename these to be
consistent with CHECK macros and save characters in the code.<br>
thanks,<br>
Coleen<br>
<br>
</font>
<meta charset="utf-8">
<pre style="color: rgb(0, 0, 0); font-style: normal; font-variant: normal; \
font-weight: normal; letter-spacing: normal; line-height: normal; orphans: auto; \
text-align: start; text-indent: 0px; text-transform: none; widows: auto; \
word-spacing: 0px; -webkit-text-stroke-width: 0px;"><font \
color="blue"><b>CHECK_JNI_EXCEPTION_RETURN_VALUE to
CHECK_JNI_EXCEPTION_() with underscore
and
CHECK_JNI_EXCEPTION_RETURN
to
CHECK_JNI_EXCEPTION()
</b></font>
</pre>
<div class="moz-cite-prefix">On 2/10/14 2:56 PM, Calvin Cheung
wrote:<br>
</div>
<blockquote cite="mid:52F92ED2.7080907@oracle.com" \
type="cite">
This fix is for adding JNI exception pending check in several
files under src/share/vm/prims directory. <br>
<br>
bug: <a moz-do-not-send="true" class="moz-txt-link-freetext"
href="https://bugs.openjdk.java.net/browse/JDK-8028785">https://bugs.openjdk.java.net/browse/JDK-8028785</a>
(non-open bug) <br>
<br>
webrev: <a moz-do-not-send="true"
class="moz-txt-link-freetext"
href="http://cr.openjdk.java.net/%7Eccheung/8028785/webrev/">http://cr.openjdk.java.net/~ccheung/8028785/webrev/</a>
<br>
<br>
Tests: <br>
jprt <br>
vm.quick (on linux-x64) <br>
<br>
Please review. <br>
<br>
thanks, <br>
Calvin <br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic