[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR: JDK-8033931: Several nightly tests failing with assert(imin < imax)
From:       Gerald Thornbrugh <gerald.thornbrugh () oracle ! com>
Date:       2014-02-07 19:36:35
Message-ID: 52F535C3.4070304 () oracle ! com
[Download RAW message or body]

Hi Coleen,

Thanks for the review.

Gerald
>
> Looks good.
> Coleen
>
> On 2/7/14 1:16 PM, Gerald Thornbrugh wrote:
>> Hi,
>>
>> In my Linux code cleanup I miscalculated an assert statement.
>> Instead of "assert(imin < imax," it should have been "assert(imin <= 
>> imax,".
>> I have rerun UTE tests and this fix address the test failures.
>>
>> Bug:
>>
>> https://bugs.openjdk.java.net/browse/JDK-8033931
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~dcubed/gthornbr/8033931-webrev/ 
>> <http://cr.openjdk.java.net/%7Edcubed/gthornbr/8033931-webrev/>
>>
>> Please review my changes and let me know if you have questions.
>>
>> Thanks,
>>
>> Gerald Thornbrugh
>


[Attachment #3 (text/html)]

<html>
  <head>
    <meta content="text/html; charset=ISO-8859-1"
      http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    <div class="moz-cite-prefix">Hi Coleen,<br>
      <br>
      Thanks for the review.<br>
      <br>
      Gerald<br>
    </div>
    <blockquote cite="mid:52F53416.1090600@oracle.com" type="cite">
      <meta content="text/html; charset=ISO-8859-1"
        http-equiv="Content-Type">
      <br>
      <font size="+1">Looks good.<br>
        Coleen<br>
        <br>
      </font>
      <div class="moz-cite-prefix">On 2/7/14 1:16 PM, Gerald Thornbrugh
        wrote:<br>
      </div>
      <blockquote cite="mid:52F522E1.8030205@oracle.com" type="cite">Hi,
        <br>
        <br>
        In my Linux code cleanup I miscalculated an assert statement. <br>
        Instead of "assert(imin &lt; imax," it should have been
        "assert(imin &lt;= imax,". <br>
        I have rerun UTE tests and this fix address the test failures. <br>
        <br>
        Bug: <br>
        <br>
        <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="https://bugs.openjdk.java.net/browse/JDK-8033931">https://bugs.openjdk.java.net/browse/JDK-8033931</a>
  <br>
        <br>
        Webrev: <br>
        <br>
        <a moz-do-not-send="true" class="moz-txt-link-freetext"
          href="http://cr.openjdk.java.net/%7Edcubed/gthornbr/8033931-webrev/">http://cr.openjdk.java.net/~dcubed/gthornbr/8033931-webrev/</a>
  <a moz-do-not-send="true" class="moz-txt-link-rfc2396E"
          href="http://cr.openjdk.java.net/%7Edcubed/gthornbr/8033931-webrev/">&lt;http://cr.openjdk.java.net/%7Edcubed/gthornbr/8033931-webrev/&gt;</a>
  <br>
        <br>
        Please review my changes and let me know if you have questions.
        <br>
        <br>
        Thanks, <br>
        <br>
        Gerald Thornbrugh <br>
      </blockquote>
      <br>
    </blockquote>
    <br>
  </body>
</html>



[prev in list] [next in list] [prev in thread] [next in thread]

Configure | About | News | Add a list | Sponsored by KoreLogic