[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-hotspot-runtime-dev
Subject: Re: RFR(M): 8032462 Change the linux SDT implementation to use USDT2 instead of USDT1
From: Coleen Phillimore <coleen.phillimore () oracle ! com>
Date: 2014-01-29 15:52:52
Message-ID: 52E923D4.1030309 () oracle ! com
[Download RAW message or body]
Ok, good!
Coleen
On 1/29/14 3:17 AM, Staffan Larsen wrote:
> Thanks Coleen!
>
> I am planning to remove all the "#ifndef USDT2” stuff in an upcoming
> change.
>
> /Staffan
>
> On 28 jan 2014, at 22:34, Coleen Phillimore
> <coleen.phillimore@oracle.com <mailto:coleen.phillimore@oracle.com>>
> wrote:
>
> >
> > This looks like a good improvement. I was hoping when I clicked on
> > this that since USDT1 can be discontinued, you could remove the code
> > under the ifndef USDT2 macros, ie:
> > 62 #ifndef USDT2
> > 63
> > 64 #define DTRACE_PROBE(a,b) {;}
> > 65 #define DTRACE_PROBE1(a,b,c) {;}
> > 66 #define DTRACE_PROBE2(a,b,c,d) {;}
> > 67 #define DTRACE_PROBE3(a,b,c,d,e) {;}
> >
> > Or is this in an upcoming change, or can you not do this yet?
> > Thanks,
> > Coleen
> > On 1/28/14 3:52 AM, Staffan Larsen wrote:
> > > Still looking for reviewers for this change.
> > >
> > > Thanks,
> > > /Staffan
> > >
> > > On 23 jan 2014, at 08:36, Staffan Larsen<staffan.larsen@oracle.com> wrote:
> > >
> > > > The only usage today of the DTrace macros under the USDT1 define is the SDT \
> > > > provider on linux. This can be changed to use the USDT2 style by \
> > > > preprocessing the .d files into .h files with the dtrace utility in the same \
> > > > way as we do on solaris and OS X.
> > > > I have also moved the provider definition files (hotspot.d, hotspot_jni.d and \
> > > > hs_private.d) to a common directory instead of having one identical copy per \
> > > > platform.
> > > > I would really like to have a review from somebody on the IcedTea team since \
> > > > I haven’t been able to fully verify this change by running systemtap.
> > > > Once this change is done, we can proceed to remove the USDT1 style macros.
> > > >
> > > > webrev:http://cr.openjdk.java.net/~sla/8032462/webrev.00/
> > > > bug:https://bugs.openjdk.java.net/browse/JDK-8032462
> > > >
> > > > testing: vm.dtrace.testlist in nsk
> > > >
> > > > Thanks,
> > > > /Staffan
> >
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<font size="+1">Ok, good!<br>
Coleen<br>
<br>
</font>
<div class="moz-cite-prefix">On 1/29/14 3:17 AM, Staffan Larsen
wrote:<br>
</div>
<blockquote
cite="mid:D9977459-54E7-49C3-A63B-6982C670877A@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=windows-1252">
<div>Thanks Coleen!</div>
<div><br>
</div>
I am planning to remove all the "#ifndef USDT2” stuff in an
upcoming change.
<div><br>
</div>
<div>/Staffan</div>
<div><br>
<div>
<div>On 28 jan 2014, at 22:34, Coleen Phillimore <<a
moz-do-not-send="true"
href="mailto:coleen.phillimore@oracle.com">coleen.phillimore@oracle.com</a>>
wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta content="text/html; charset=windows-1252"
http-equiv="Content-Type">
<div text="#000000" bgcolor="#FFFFFF"> <br>
<font size="+1">This looks like a good improvement. I was
hoping when I clicked on this that since USDT1 can be
discontinued, you could remove the code under the ifndef
USDT2 macros, ie:</font><br>
<meta charset="utf-8">
<pre style="font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; \
-webkit-text-stroke-width: 0px;"> 62 #ifndef USDT2 63
64 #define DTRACE_PROBE(a,b) {;}
65 #define DTRACE_PROBE1(a,b,c) {;}
66 #define DTRACE_PROBE2(a,b,c,d) {;}
67 #define DTRACE_PROBE3(a,b,c,d,e) {;}
</pre>
Or is this in an upcoming change, or can you not do this
yet?<br>
Thanks,<br>
Coleen<br>
<pre style="font-style: normal; font-variant: normal; font-weight: \
normal; letter-spacing: normal; line-height: normal; orphans: auto; text-align: \
start; text-indent: 0px; text-transform: none; widows: auto; word-spacing: 0px; \
-webkit-text-stroke-width: 0px;">On 1/28/14 3:52 AM, Staffan Larsen wrote: </pre>
<blockquote
cite="mid:AB6471DE-64EA-4ABC-9334-F3250EF2860D@oracle.com"
type="cite">
<pre wrap="">Still looking for reviewers for this change.
Thanks,
/Staffan
On 23 jan 2014, at 08:36, Staffan Larsen <a moz-do-not-send="true" \
class="moz-txt-link-rfc2396E" \
href="mailto:staffan.larsen@oracle.com"><staffan.larsen@oracle.com></a> wrote:
</pre>
<blockquote type="cite">
<pre wrap="">The only usage today of the DTrace macros under the \
USDT1 define is the SDT provider on linux. This can be changed to use the USDT2 style \
by preprocessing the .d files into .h files with the dtrace utility in the same way \
as we do on solaris and OS X.
I have also moved the provider definition files (hotspot.d, hotspot_jni.d and \
hs_private.d) to a common directory instead of having one identical copy per \
platform.
I would really like to have a review from somebody on the IcedTea team since I \
haven’t been able to fully verify this change by running systemtap.
Once this change is done, we can proceed to remove the USDT1 style macros.
webrev: <a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/%7Esla/8032462/webrev.00/">http://cr.openjdk.java.net/~sla/8032462/webrev.00/</a>
bug: <a moz-do-not-send="true" class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8032462">https://bugs.openjdk.java.net/browse/JDK-8032462</a>
testing: vm.dtrace.testlist in nsk
Thanks,
/Staffan
</pre>
</blockquote>
</blockquote>
<br>
</div>
</blockquote>
</div>
<br>
</div>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic