[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-hotspot-runtime-dev
Subject: Re: RFR 8028275: Metaspace ShrinkGrowTest causes fatal error if run with JFR
From: Coleen Phillimore <coleen.phillimore () oracle ! com>
Date: 2014-01-28 4:11:49
Message-ID: 52E72E05.2040605 () oracle ! com
[Download RAW message or body]
Thanks, David.
Coleen
On 1/27/14 9:43 PM, David Holmes wrote:
> On 25/01/2014 11:05 AM, Coleen Phillimore wrote:
>>
>> Thanks Harold! Hoping the other reviewer will see this too (David?)
>
> Yep - looks good to me (sorry was a holiday weekend here)
>
> It is scary how much ancient crud we still carry around :(
>
> Thanks,
> david
>
>> Coleen
>>
>> On 1/24/14 4:52 PM, harold seigel wrote:
>>> Hi Coleen,
>>>
>>> That looks a lot cleaner.
>>>
>>> Thanks, Harold
>>>
>>> On 1/24/2014 2:53 PM, Coleen Phillimore wrote:
>>>>
>>>> In a separate email Harold pointed out that we'd investigated the
>>>> early java.lang.Compiler initialization and found it wasn't needed
>>>> because the ancient bug it was working around is fixed. I verified
>>>> this with the ancient test case as well.
>>>>
>>>> New webrev of additional code cleanup is here. Retested against
>>>> vm.quick.testlist.
>>>>
>>>> http://cr.openjdk.java.net/~coleenp/8028275_2/
>>>>
>>>> Thanks,
>>>> Coleen
>>>>
>>>> On 1/23/14 1:43 PM, harold seigel wrote:
>>>>> Hi Coleen,
>>>>>
>>>>> Your changes look good.
>>>>>
>>>>> Thanks, Harold
>>>>>
>>>>> On 1/16/2014 5:46 PM, Coleen Phillimore wrote:
>>>>>> Summary: Clean up initialization from Threads::create_vm() so that
>>>>>> exceptions cause vm_exit_during_initialization without an exception
>>>>>> mark.
>>>>>>
>>>>>> My attempt at cleaning up initialization code paths that can throw
>>>>>> an exception. I only cleaned up the code in Threads::create_vm().
>>>>>> There are other places where EXCEPTION_MARK can occur after
>>>>>> Universe::is_fully_initialized() and before
>>>>>> is_initialization_complete() deeply embedded in the code. But I did
>>>>>> some refactoring.
>>>>>>
>>>>>> open webrev at http://cr.openjdk.java.net/~coleenp/8028275/
>>>>>> bug link https://bugs.openjdk.java.net/browse/JDK-8028275
>>>>>>
>>>>>> Tested with nsk.quick.testlist and with the hotspot jtreg tests,
>>>>>> and some custom code to test exception paths.
>>>>>>
>>>>>> Thanks,
>>>>>> Coleen
>>>>>>
>>>>>
>>>>
>>>
>>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
<font size="+1">Thanks, David.<br>
Coleen<br>
<br>
</font>
<div class="moz-cite-prefix">On 1/27/14 9:43 PM, David Holmes wrote:<br>
</div>
<blockquote cite="mid:52E71966.3020105@oracle.com" type="cite">On
25/01/2014 11:05 AM, Coleen Phillimore wrote:
<br>
<blockquote type="cite">
<br>
Thanks Harold! Hoping the other reviewer will see this too
(David?)
<br>
</blockquote>
<br>
Yep - looks good to me (sorry was a holiday weekend here)
<br>
<br>
It is scary how much ancient crud we still carry around :(
<br>
<br>
Thanks,
<br>
david
<br>
<br>
<blockquote type="cite">Coleen
<br>
<br>
On 1/24/14 4:52 PM, harold seigel wrote:
<br>
<blockquote type="cite">Hi Coleen,
<br>
<br>
That looks a lot cleaner.
<br>
<br>
Thanks, Harold
<br>
<br>
On 1/24/2014 2:53 PM, Coleen Phillimore wrote:
<br>
<blockquote type="cite">
<br>
In a separate email Harold pointed out that we'd
investigated the
<br>
early java.lang.Compiler initialization and found it wasn't
needed
<br>
because the ancient bug it was working around is fixed. I
verified
<br>
this with the ancient test case as well.
<br>
<br>
New webrev of additional code cleanup is here. Retested
against
<br>
vm.quick.testlist.
<br>
<br>
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~coleenp/8028275_2/">http://cr.openjdk.java.net/~coleenp/8028275_2/</a>
<br>
<br>
Thanks,
<br>
Coleen
<br>
<br>
On 1/23/14 1:43 PM, harold seigel wrote:
<br>
<blockquote type="cite">Hi Coleen,
<br>
<br>
Your changes look good.
<br>
<br>
Thanks, Harold
<br>
<br>
On 1/16/2014 5:46 PM, Coleen Phillimore wrote:
<br>
<blockquote type="cite">Summary: Clean up initialization
from Threads::create_vm() so that
<br>
exceptions cause vm_exit_during_initialization without
an exception
<br>
mark.
<br>
<br>
My attempt at cleaning up initialization code paths that
can throw
<br>
an exception. I only cleaned up the code in
Threads::create_vm().
<br>
There are other places where EXCEPTION_MARK can occur
after
<br>
Universe::is_fully_initialized() and before
<br>
is_initialization_complete() deeply embedded in the
code. But I did
<br>
some refactoring.
<br>
<br>
open webrev at
<a class="moz-txt-link-freetext" \
href="http://cr.openjdk.java.net/~coleenp/8028275/">http://cr.openjdk.java.net/~coleenp/8028275/</a>
<br>
bug link
<a class="moz-txt-link-freetext" \
href="https://bugs.openjdk.java.net/browse/JDK-8028275">https://bugs.openjdk.java.net/browse/JDK-8028275</a>
<br>
<br>
Tested with nsk.quick.testlist and with the hotspot
jtreg tests,
<br>
and some custom code to test exception paths.
<br>
<br>
Thanks,
<br>
Coleen
<br>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
<br>
</blockquote>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic