[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR(XS): 8032386: Argument auto-correct suggests arguments which are constant in the binary
From:       David Holmes <david.holmes () oracle ! com>
Date:       2014-01-22 6:51:53
Message-ID: 52DF6A89.5070002 () oracle ! com
[Download RAW message or body]

I closed 8032386 as a dup of 8027314 before seeing this RFR.

Thanks,
David

On 22/01/2014 10:51 AM, Vladimir Kozlov wrote:
> Gilles,
>
> Please look on next changes 8027314 which was just pushed:
>
> http://hg.openjdk.java.net/jdk9/hs-rt/hotspot/rev/234d576115b5
>
> The message for develop flags in product VM is changed to:
>
> Error: VM option 'PrintMethodFlushing' is develop and is available only
> in debug version of VM.
>
> Regards,
> Vladimir
>
> On 1/21/14 6:02 AM, Gilles Duboscq wrote:
>> Hello,
>>
>> As i wrote in the bug report [1]:
>> With a product build (note that PrintMethodFlushing is a 'develop' flag):
>>
>>> java -XX:+PrintMethodFlushing
>> Unrecognized VM option 'PrintMethodFlushing'
>> Did you mean '(+/-)PrintMethodFlushing'?
>> Error: Could not create the Java Virtual Machine.
>> Error: A fatal exception has occurred. Program will exit.
>>
>> This will probably confuse users.
>>
>> As a fix, I propose to ignore arguments which are constant in the
>> binary while trying to find a fuzzy match [2]. I think the policy is
>> to act as if constant options didn't exist in product builds so this
>> is probably better than telling the user that this option can not be
>> set in the current build.
>>
>> -Gilles
>>
>> [1] https://bugs.openjdk.java.net/browse/JDK-8032386
>> [2] http://lafo.ssw.uni-linz.ac.at/fuzzy-constant.diff
>>
[prev in list] [next in list] [prev in thread] [next in thread]