[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Re: RFR (XS): 7015395: Make sure the test compiles and completes its intended run.
From:       Gerard Ziemski <gerard.ziemski () oracle ! com>
Date:       2014-01-17 17:38:16
Message-ID: 52D96A88.1080103 () oracle ! com
[Download RAW message or body]

Thank you Frederic!

On 1/17/2014 11:00 AM, frederic parain wrote:
> Fix looks good according to the description in the CR.
>
> Fred
>
> On 17/01/2014 17:23, Gerard Ziemski wrote:
>> Thank you Coleen!
>>
>> I still need a 2nd review to be able to check this small fix in.
>>
>>
>> cheers
>>
>> On 1/16/2014 2:02 PM, Coleen Phillimore wrote:
>>>
>>> Looks good.
>>> Coleen
>>>
>>> On 01/16/2014 02:15 PM, Gerard Ziemski wrote:
>>>> hi all,
>>>>
>>>> Can I have a review for a very small change to a nightly test script
>>>> to make sure it compiles and completes its run?
>>>>
>>>> The script here compiles base classes with a provided loader, then
>>>> later tries to substitute another loader to compile it against the
>>>> base classes. This might fail, however, if the base classes get
>>>> copied and compiled fast enough to have the same timestamps.
>>>>
>>>> I think the proposed solution which inserts 2 second delay between
>>>> when the files get copied and when they get compiled is simple and
>>>> sufficient enough to guarantee that the final compilation step 
>>>> succeeds.
>>>>
>>>> References:
>>>>
>>>> webrev: http://cr.openjdk.java.net/~gziemski/7015395/
>>>> CR: https://bugs.openjdk.java.net/browse/JDK-7015395
>>>>
>>>>
>>>> cheers
>>>
>>>
>>>
>>
>

[prev in list] [next in list] [prev in thread] [next in thread]