[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-hotspot-runtime-dev
Subject: Re: RFR(S) 8014294: Assert in ThreadTimesClosure::do_thread() due to use of naked oop instead of han
From: Coleen Phillmore <coleen.phillimore () oracle ! com>
Date: 2013-07-25 21:42:02
Message-ID: 51F19BAA.8050402 () oracle ! com
[Download RAW message or body]
I agree, this fix looks good. Thanks Christian!
Coleen
On 7/25/2013 5:04 PM, serguei.spitsyn@oracle.com wrote:
> Hi Christian,
>
> The fix is good.
>
> Thanks,
> Serguei
>
> On 7/25/13 1:56 PM, Christian Tornqvist wrote:
>>
>> Small fix for an assertion due to a use of a naked oop, reproduces
>> with the original regression test. The fix has been tested by running
>> vm.quick locally on my Windows machine and using the original
>> regression test.
>>
>> Webrev:
>>
>> http://cr.openjdk.java.net/~ctornqvi/webrev/8014294/webrev.00/
>> <http://cr.openjdk.java.net/%7Ectornqvi/webrev/8014294/webrev.00/>
>>
>> Bug:
>>
>> http://bugs.sun.com/view_bug.do?bug_id=8014294
>>
>> Thanks,
>>
>> Christian
>>
>
[Attachment #3 (text/html)]
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body text="#000000" bgcolor="#FFFFFF">
<br>
I agree, this fix looks good. Thanks Christian!<br>
<br>
Coleen<br>
<br>
<div class="moz-cite-prefix">On 7/25/2013 5:04 PM,
<a class="moz-txt-link-abbreviated" \
href="mailto:serguei.spitsyn@oracle.com">serguei.spitsyn@oracle.com</a> wrote:<br> \
</div> <blockquote cite="mid:51F192E0.8020407@oracle.com" type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div class="moz-cite-prefix">Hi Christian,<br>
<br>
The fix is good.<br>
<br>
Thanks,<br>
Serguei<br>
<br>
On 7/25/13 1:56 PM, Christian Tornqvist wrote:<br>
</div>
<blockquote cite="mid:019f01ce8979$81f665e0$85e331a0$@oracle.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<meta name="Generator" content="Microsoft Word 15 (filtered
medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:#0563C1;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:#954F72;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
<div class="WordSection1">
<p class="MsoNormal">Small fix for an assertion due to a use
of a naked oop, reproduces with the original regression
test. The fix has been tested by running vm.quick locally on
my Windows machine and using the original regression test.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Webrev:<o:p></o:p></p>
<p class="MsoNormal"><a moz-do-not-send="true"
href="http://cr.openjdk.java.net/%7Ectornqvi/webrev/8014294/webrev.00/"> \
http://cr.openjdk.java.net/~ctornqvi/webrev/8014294/webrev.00/</a><o:p></o:p></p> <p \
class="MsoNormal"><o:p> </o:p></p> <p class="MsoNormal">Bug:<o:p></o:p></p>
<p class="MsoNormal"><a moz-do-not-send="true"
href="http://bugs.sun.com/view_bug.do?bug_id=8014294">http://bugs.sun.com/view_bug.do?bug_id=8014294</a><o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Thanks,<o:p></o:p></p>
<p class="MsoNormal">Christian<o:p></o:p></p>
</div>
</blockquote>
<br>
</blockquote>
<br>
</body>
</html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic