[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-hotspot-runtime-dev
Subject: RE: RFR (M) 8005013: Add NMT tests
From: Christian Törnqvist <christian.tornqvist () oracle ! com>
Date: 2013-01-24 14:17:42
Message-ID: 51a6d78d-b13f-410e-adef-fab21f4ca34e () default
[Download RAW message or body]
It might fail if people haven't updated their jtreg, all the machines in the test lab \
should have been updated though. The updated jtreg is from November 29th so it's not \
that recent :)
Thanks,
Christian
From: Coleen Phillimore
Sent: den 24 januari 2013 15:12
To: Christian Törnqvist
Cc: hotspot-runtime-dev@openjdk.java.net
Subject: Re: RFR (M) 8005013: Add NMT tests
On 1/24/2013 7:21 AM, Christian Törnqvist wrote:
Hi Coleen,
> Does having @library /testlibrary tell jtreg to compile the java code in \
> test/library? Does this work today or do you have to wait for a version of jtreg \
> to support it?
Yes, it'll add /testlibrary to the classpath both when running and compiling the \
test. The @library tag has been in jtreg for a long time, however it required a \
relative path until a recent change in jtreg that added support for '/' to add an \
absolute path from the test root.
Thanks,
Christian
From: Coleen Phillimore
Sent: den 23 januari 2013 18:49
To: HYPERLINK "mailto:hotspot-runtime-dev@openjdk.java.net"hotspot-runtime-dev@openjdk.java.net
Subject: Re: RFR (M) 8005013: Add NMT tests
Christian,
These tests look great. Using ProcessBuilder to run commands and checking their \
output is so much better than the shell scripts we've used to do this.
Does having @library /testlibrary tell jtreg to compile the java code in \
test/library? Does this work today or do you have to wait for a version of jtreg to \
support it?
Okay, so my question is: if you check it in today, will it fail anywhere because this \
recent change isn't available somewhere? Since these are in the Hotspot repository \
and we don't run jtreg tests in JPRT, then all you need to do is publish the right \
version of jtreg so people individually don't fail these tests, is that correct?
Thanks,
Coleen
Thanks,
Coleen
On 01/10/2013 06:17 AM, Christian Törnqvist wrote:
Hi everyone,
These are tests written for the Native Memory Tracking feature along with a few \
helper classes, some of the tests depend on the WB API changes made in 8005012 to \
function properly. Webrev can be found at HYPERLINK \
"http://cr.openjdk.java.net/%7Eehelin/8005013/webrev.00/"http://cr.openjdk.java.net/~ehelin/8005013/webrev.00/
Thanks,
Christian
[Attachment #3 (text/html)]
<html xmlns:v="urn:schemas-microsoft-com:vml" \
xmlns:o="urn:schemas-microsoft-com:office:office" \
xmlns:w="urn:schemas-microsoft-com:office:word" \
xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" \
xmlns="http://www.w3.org/TR/REC-html40"><head><meta http-equiv=Content-Type \
content="text/html; charset=iso-8859-1"><meta name=Generator content="Microsoft Word \
12 (filtered medium)"><style><!-- /* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
@font-face
{font-family:"Times New Roman \, serif";
panose-1:0 0 0 0 0 0 0 0 0 0;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0cm;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.MsoAcetate, li.MsoAcetate, div.MsoAcetate
{mso-style-priority:99;
mso-style-link:"Balloon Text Char";
margin:0cm;
margin-bottom:.0001pt;
font-size:8.0pt;
font-family:"Tahoma","sans-serif";
color:black;}
p.MsoListParagraph, li.MsoListParagraph, div.MsoListParagraph
{mso-style-priority:34;
margin-top:0cm;
margin-right:0cm;
margin-bottom:0cm;
margin-left:36.0pt;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";
color:black;}
span.EmailStyle18
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.EmailStyle19
{mso-style-type:personal;
font-family:"Calibri","sans-serif";
color:#1F497D;}
span.BalloonTextChar
{mso-style-name:"Balloon Text Char";
mso-style-priority:99;
mso-style-link:"Balloon Text";
font-family:"Tahoma","sans-serif";
color:black;}
span.EmailStyle22
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-size:10.0pt;}
@page WordSection1
{size:612.0pt 792.0pt;
margin:70.85pt 70.85pt 70.85pt 70.85pt;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body bgcolor=white lang=SV link=blue \
vlink=purple><div class=WordSection1><p class=MsoNormal><span lang=EN-US \
style='color:#1F497D'>It might fail if people haven’t updated their jtreg, all \
the machines in the test lab should have been updated though. The updated jtreg is \
from November 29<sup>th</sup> so it’s not that recent \
:)<o:p></o:p></span></p><p class=MsoNormal><span lang=EN-US \
style='color:#1F497D'><o:p> </o:p></span></p><p class=MsoNormal><span lang=EN-US \
style='color:#1F497D'>Thanks,<o:p></o:p></span></p><p class=MsoNormal><span \
lang=EN-US style='color:#1F497D'>Christian<i><o:p></o:p></i></span></p><p \
class=MsoNormal><span lang=EN-US \
style='color:#1F497D'><o:p> </o:p></span></p><div><div \
style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p \
class=MsoNormal><b><span lang=EN-US \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'>From:</span></b><span \
lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'> \
Coleen Phillimore <br><b>Sent:</b> den 24 januari 2013 15:12<br><b>To:</b> Christian \
Törnqvist<br><b>Cc:</b> hotspot-runtime-dev@openjdk.java.net<br><b>Subject:</b> Re: \
RFR (M) 8005013: Add NMT tests<o:p></o:p></span></p></div></div><p \
class=MsoNormal><o:p> </o:p></p><div><p class=MsoNormal>On 1/24/2013 7:21 AM, \
Christian Törnqvist wrote:<o:p></o:p></p></div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal><span \
style='color:#1F497D'>Hi Coleen,</span><o:p></o:p></p><p class=MsoNormal><span \
style='color:#1F497D'> </span><o:p></o:p></p><p class=MsoNormal><span \
lang=EN-US>> Does having @library /testlibrary tell jtreg to compile the \
java code in test/library? Does this work today or do you have to wait for a \
version of jtreg to support it?</span><o:p></o:p></p><p class=MsoNormal><span \
lang=EN-US> </span><o:p></o:p></p><p class=MsoNormal><span lang=EN-US>Yes, \
it’ll add /testlibrary to the classpath both when running and compiling the \
test. The @library tag has been in jtreg for a long time, however it required a \
relative path until a recent change in jtreg that added support for ‘/’ \
to add an absolute path from the test root. </span><o:p></o:p></p><p \
class=MsoNormal><span lang=EN-US> </span><o:p></o:p></p><p class=MsoNormal><span \
lang=EN-US>Thanks,</span><o:p></o:p></p><p class=MsoNormal><span \
lang=EN-US>Christian</span><o:p></o:p></p><p class=MsoNormal><span lang=EN-US \
style='color:#1F497D'> </span><o:p></o:p></p><div><div \
style='border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0cm 0cm 0cm'><p \
class=MsoNormal><b><span lang=EN-US \
style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'>From:</span></b><span \
lang=EN-US style='font-size:10.0pt;font-family:"Tahoma","sans-serif";color:windowtext'> \
Coleen Phillimore <br><b>Sent:</b> den 23 januari 2013 18:49<br><b>To:</b> <a \
href="mailto:hotspot-runtime-dev@openjdk.java.net">hotspot-runtime-dev@openjdk.java.net</a><br><b>Subject:</b> \
Re: RFR (M) 8005013: Add NMT tests</span><o:p></o:p></p></div></div><p \
class=MsoNormal> <o:p></o:p></p><p class=MsoNormal \
style='margin-bottom:12.0pt'><br>Christian,<br><br>These tests look great. \
Using ProcessBuilder to run commands and checking their output is so much better than \
the shell scripts we've used to do this.<br><br>Does having @library \
/testlibrary tell jtreg to compile the java code in test/library? Does this \
work today or do you have to wait for a version of jtreg to support \
it?<o:p></o:p></p></blockquote><p class=MsoNormal><span \
style='font-size:12.0pt;font-family:"Times New Roman","serif"'><br>Okay, so my \
question is: if you check it in today, will it fail anywhere because this recent \
change isn't available somewhere?<br>Since these are in the Hotspot repository and we \
don't run jtreg tests in JPRT, then all you need to do is publish the right version \
of jtreg so people individually don't fail these tests, is that \
correct?<br><br>Thanks,<br>Coleen<br><br><br><o:p></o:p></span></p><p class=MsoNormal \
style='margin-bottom:12.0pt'><br>Thanks,<br>Coleen<o:p></o:p></p><div><p \
class=MsoNormal>On 01/10/2013 06:17 AM, Christian Törnqvist \
wrote:<o:p></o:p></p></div><blockquote \
style='margin-top:5.0pt;margin-bottom:5.0pt'><p class=MsoNormal>Hi \
everyone,<o:p></o:p></p><p class=MsoNormal> <o:p></o:p></p><p \
class=MsoNormal><span lang=EN-US>These are tests written for the Native Memory \
Tracking feature along with a few helper classes, some of the tests depend on the WB \
API changes made in 8005012 to function properly. Webrev can be found at <a \
href="http://cr.openjdk.java.net/%7Eehelin/8005013/webrev.00/">http://cr.openjdk.java.net/~ehelin/8005013/webrev.00/</a></span><o:p></o:p></p><p \
class=MsoNormal><span lang=EN-US> </span><o:p></o:p></p><p class=MsoNormal><span \
lang=EN-US>Thanks,</span><o:p></o:p></p><p class=MsoNormal><span \
lang=EN-US>Christian</span><o:p></o:p></p></blockquote><p class=MsoNormal><span \
style='font-size:12.0pt;font-family:"Times New Roman , \
serif","serif"'> </span><o:p></o:p></p><p class=MsoNormal><span \
style='font-size:12.0pt;font-family:"Times New \
Roman","serif"'><o:p> </o:p></span></p></div></body></html>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic