[prev in list] [next in list] [prev in thread] [next in thread]
List: openjdk-hotspot-runtime-dev
Subject: RFR (M) 8005012: Add WB APIs to better support NMT testing
From: david.holmes () oracle ! com (David Holmes)
Date: 2012-12-18 23:21:06
Message-ID: 50D0FA62.6040506 () oracle ! com
[Download RAW message or body]
On 19/12/2012 12:10 AM, Christian T?rnqvist wrote:
> Hi everyone,
>
> This change is about adding three new WB APIs to better support NMT
> testing. The changes are:
>
> ?A Test memory type, used by WB API?s NMTAllocTest and NMTFreeTestMemory
>
> ?Added a WaitForDataMerge WB API to be able to block until the current
> generation has been merged and is visible, most of this work was done by
> Zhengyu Gu.
This method blocks while holding the query_lock - is that intended?
Aside: the MemSnapshot::wait method is troubling me. What are you
waiting upon ie what state condition? The notification is done in the
destructor but how can the destructor be called if someone is calling
wait() upon the object's lock ??? It means you are destroying an object
that is still in use, including the lock that is being waited upon!!!
David
-----
>
> Webrev can be found at:
>
> http://cr.openjdk.java.net/~ehelin/8005012/webrev.00/
>
> Thanks,
>
> Christian
>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic