[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RFR -Make NMT a bit friendlier to work with
From:       nils.loodin () oracle ! com (Nils Loodin)
Date:       2012-09-21 8:36:23
Message-ID: 505C2707.1000502 () oracle ! com
[Download RAW message or body]

On 09/20/2012 08:14 PM, Srinivas Ramakrishna wrote:
> Isn't that because there was an "8" instead of a "7" for the second
> comparison. Otherwise, like the previous one the comparison
> would stop at the nth character and ignore the suffix (in yr case the
> "s"). I think your change is good, but for consistency wrt the
> existing you should probably change the length of each comparison to the
> string being compared with in each case to preserve the
> existRight. I'll change thating "OK if prefixes match" property everywhere.
>
> reviewed.
> -- ramki (openjdk: ysr)

Ah, well that's true. However, it would have still silently swallowed 
the case where I mistakenly put  '=derail' instead :)

I'll change the length of the string comparison!

/Nisse

[prev in list] [next in list] [prev in thread] [next in thread]