[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    RFR: 7143353: hprof not working with invokedynamic
From:       kelly.ohair () oracle ! com (Kelly O'Hair)
Date:       2012-05-24 15:19:25
Message-ID: E6D952A7-69C1-4960-B0B9-B266F70101A7 () oracle ! com
[Download RAW message or body]

The stack requirements (char message[BUFSIZE]) for this method increasing by 256 all \
the time seems unnecessary, a fixed string plus two numerics doesn't need 256 \
characters anyway, does it? Not sure it matters that much in this case since it isn't \
in any kind of recursive call situation.

Fixed buffers bumping up the stack size needed always make my eye twitch. Worked in \
compilers too long. :^(

But I don't see anything logically wrong with the change.

-kto


On May 24, 2012, at 12:46 AM, Nils Loodin wrote:

> when the 'demo' java_crw_demo (which is used by hprof) tries to mirror the constant \
> pool of a class, a few of the constants introduced by invokedynamic ins't \
> recognized. Fairly simple fix. For my simple repro, it seems to work with this \
> patch. 
> Also slightly improved the error message for future niceness.
> 
> Webrev here: 
> http://cr.openjdk.java.net/~nloodin/7143353/webrev.00/
> 
> Regards,
> Nils Loodin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/hotspot-runtime-dev/attachments/20120524/a6d1a212/attachment-0001.html \



[prev in list] [next in list] [prev in thread] [next in thread]