[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Review request 7157734 testcase corrections (use TESTVMOPTS).
From:       gary.collins () oracle ! com (Gary Collins)
Date:       2012-03-30 15:23:58
Message-ID: EC1499C9-6D5B-4238-A458-C39B971437A8 () oracle ! com
[Download RAW message or body]

Not only do the shell need to pass this so does the @run line in java files. I've not \
added this but would assume we should. 

Maybe someone in quality can confirm the proper flags to put in each script and java \
file to allow all tests to be used. 



Gary




On Mar 30, 2012, at 10:30 AM, Kevin Walls <kevin.walls at oracle.com> wrote:

> Hi,
> 
> Various hotpsot .sh testcase scripts do not use the env var TESTVMOPTS, which is \
> passed by jtreg.  They therefore don't set -d64 when we want to test a 64-bit JVM \
> and on Solaris at least this means we don't test what we think we're testing.  We \
> actually run a 32-bit JVM, and likely not even the one we just built to test. 
> What some testcases do do, is to read $HOME/JDK64BIT if it exists, and use the file \
> contents as command-line arguments, or even just as a flag to know that we should \
> set -d64 when we run java.  It seems best to get rid of this practice.  I have \
> asked around and found nobody who can say that technique is still in use. 
> http://cr.openjdk.java.net/~kevinw/7157734.1/webrev/
> 
> Thanks
> Kevin


[prev in list] [next in list] [prev in thread] [next in thread]