[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Patch to enable ccache to work most of the time.
From:       kelly.ohair () oracle ! com (Kelly O'Hair)
Date:       2012-01-23 17:42:48
Message-ID: 5F13B1B5-6B51-4275-AC7A-781836F9B727 () oracle ! com
[Download RAW message or body]



I can be a reviewer. Looks good.

And I appreciate the makefile comment :^)

I think this also explains some strange behaviors with pre-compiled headers.
If the version number definition gets into the pre-compiled header file, it becomes \
invalid with any version string change and can cause build failures, or at least on \
windows it has.

-kto

On Jan 23, 2012, at 9:05 AM, Fredrik ?hrstr?m wrote:

> Simple fix to prevent the version define to be passed to all Hotspot c++ files.
> 
> Since the version define contains a time and date (when the build nr is not \
> set),the ccache can only be used for 1 minute after the build.... 
> This fix makes sure that only vm_version.o depends on the version number. Thus all \
> the other files can be ccached efficiently. 
> http://cr.openjdk.java.net/~ohrstrom/webrev-2012-01-23-prep-for-ccache/
> 
> Jim, can you make me an author on HSX?
> 
> Robert, can you sponsor me?
> 
> //Fredrik
> 


[prev in list] [next in list] [prev in thread] [next in thread]