[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Request for review: 7112308 Fix Visual Studio build for precompiled header
From:       bengt.rutisson () oracle ! com (Bengt Rutisson)
Date:       2011-11-21 13:25:42
Message-ID: 4ECA5156.2010404 () oracle ! com
[Download RAW message or body]

On 2011-11-18 15:48, Daniel D. Daugherty wrote:
> I think this is one of the few cases where a push to Main_Baseline
> would be warranted. Particularly since more folks are starting to
> use Visual Studio (again...)

Good point, Dan. I was not really sure what kind of approval I needed to 
push directly to hotspot-main. So, finally I decided on pushing this fix 
to hotspot-rt in the hope that it will be integrated up to hotspot-main 
tomorrow. I *think* that the runtime team normally integrates on Tuesdays.

In that case I can pull it down into hotspot-gc on Wednesday.

Thanks,
Bengt

>
> Dan
>
>
>
>> Thanks for the review Bengt,
>> feel free to push it for me as I don't have the right role to do so.
>>
>> On Nov 18, 2011, at 9:17 AM, Bengt Rutisson wrote:
>>
>>> Rickard,
>>>
>>> Thanks for finding this! Your fix looks good. Just verified a Visual 
>>> Studio build with your changes applied. Works fine.
>> I'll give credit to Karen who filed the bug.
>>
>>>
>>> I assume you need this in hotspot-rt as soon as possible. But I 
>>> anyway just want to ask if there is any chance of pushing this 
>>> through hotspot-gc instead?
>>>
>>> Tony integrated hotspot-gc and hotspot-main yesterday. That 
>>> integration brought your original precompiled.hpp change over to 
>>> hotspot-gc. So, up until now I have not had any problems with my VS 
>>> projects. Now I guess they will be broken until your new change has 
>>> propagated from hotspot-rt to hotspot-gc...
>>>
>>> But if you need it in hotspot-rt you will have the same issue. So 
>>> there is really no good solution. Just thought I'd ask.
>>>
>>> Bengt
>>>
>>>
>>> On 2011-11-17 16:04, Rickard B?ckman wrote:
>>>> Hi All,
>>>>
>>>> my move of the precompiled header broke the project file creation 
>>>> for Visual Studio. Here is a small fix to the problem:
>>>>
>>>> 7112308: Fix Visual Studio build for precompiled header
>>>> http://cr.openjdk.java.net/~rbackman/7112308/
>>>>
>>>> Thanks
>>>> Rickard


[prev in list] [next in list] [prev in thread] [next in thread]