[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-runtime-dev
Subject:    Simple Request for review: 6535709 - lost interrupts on win32
From:       David.Holmes () oracle ! com (David Holmes)
Date:       2011-03-21 2:31:20
Message-ID: 4D86B878.40500 () oracle ! com
[Download RAW message or body]

Hi Dan,

Daniel D. Daugherty said the following on 03/21/11 12:12:
> On 3/20/2011 7:46 PM, David Holmes wrote:
>> http://cr.openjdk.java.net/~dholmes/6535709/webrev/
> Thumbs up.

Thanks for the review.

> Nice fix. And very nice analysis in the bug report(s).
> I'm going to crawl over the Serviceability bugs because I
> think there are a couple that are "interrupt related".

I did take a quick run through myself to see if there were others, but I 
didn't see anything obviously Windows+interrupt specific.

> src/share/vm/runtime/vmStructs.cpp
>    Did you mean to change the comment starter on line 1?

Nope. Fixed.

David

> Dan
> 
> 
>>
>> A trivial fix (in the end) for an issue already avoided on 
>> Solaris/Linux. It finally closes a set of bugs that have been open for 
>> years.
>>
>> David

[prev in list] [next in list] [prev in thread] [next in thread]