[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8314480: Memory ordering spec updates in java.lang.ref [v31]
From:       Alan Bateman <alanb () openjdk ! org>
Date:       2024-05-13 10:06:17
Message-ID: ufZ1AXkEQIGA2clflsy6higNjS_OgikBtOrQwssBNHc=.5480f106-88b5-424d-aa1a-996fadbc7d91 () github ! com
[Download RAW message or body]

On Thu, 9 May 2024 18:44:10 GMT, Brent Christian <bchristi@openjdk.org> wrote:

> > Classes in the `java.lang.ref` package would benefit from an update to bring the \
> > spec in line with how the VM already behaves. The changes would focus on \
> > _happens-before_ edges at some key points during reference processing. 
> > A couple key things we want to be able to say are:
> > - `Reference.reachabilityFence(x)` _happens-before_ reference processing occurs \
> >                 for 'x'.
> > - `Cleaner.register()` _happens-before_ the Cleaner thread runs the registered \
> > cleaning action. 
> > This will bring Cleaner in line (or close) with the memory visibility guarantees \
> > made for finalizers in [JLS \
> > 17.4.5](https://docs.oracle.com/javase/specs/jls/se18/html/jls-17.html#jls-17.4.5):
> >  _"There is a happens-before edge from the end of a constructor of an object to \
> > the start of a finalizer ( §12.6) for that object."_
> 
> Brent Christian has updated the pull request incrementally with one additional \
> commit since the last revision: 
> add link to Thread.isAlive()

You've addressed my comments, I don't have anything else.

-------------

Marked as reviewed by alanb (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/16644#pullrequestreview-2052249974


[prev in list] [next in list] [prev in thread] [next in thread]