[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: JDK-8267562: G1: Missing BOT in Open Archive regions causes long pauses [v2]
From:       Jiangli Zhou <jiangli () openjdk ! java ! net>
Date:       2021-05-31 19:42:28
Message-ID: 6_8pkOLknu_-RIy9uTRZ8mWwOvMdLxC867qii8V_eD0=.297be284-3017-4937-af88-8f571f7f113a () github ! com
[Download RAW message or body]

On Mon, 31 May 2021 08:27:03 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:

> > Jiangli Zhou has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > Updated comment based on the review feedback from Thomas.
> 
> src/hotspot/share/cds/filemap.cpp line 2053:
> 
> > 2051:     // Populate the open archive regions' G1BlockOffsetTableParts. That \
> >                 ensures
> > 2052:     // fast G1BlockOffsetTablePart::block_start operations for a given \
> >                 address
> > 2053:     // within the open archive regions during \
> > G1RemSet::refine_card_concurrently.
> 
> Not only refinement is subject to the issue but any operation trying to find start \
> of an object (e.g. card table scanning). Please fix the comment accordingly.

Updated comment based on the feedback from Thomas. Thanks for the review.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4265


[prev in list] [next in list] [prev in thread] [next in thread]