[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8267836: Separate eager reclaim remembered set threshold from G1RSetSparseRegionEntries [v2
From:       Thomas Schatzl <tschatzl () openjdk ! java ! net>
Date:       2021-05-31 12:16:43
Message-ID: BZ9zVNVoh6garfVyfKNDot0m0MSdXTaUnom4YVppM38=.508e766f-b0c6-4d79-9f97-6b82885dacf0 () github ! com
[Download RAW message or body]

On Mon, 31 May 2021 11:05:53 GMT, Leo Korinth <lkorinth@openjdk.org> wrote:

> > Thomas Schatzl has updated the pull request incrementally with one additional \
> > commit since the last revision: 
> > lkorinth review
> 
> src/hotspot/share/gc/g1/g1Arguments.cpp line 58:
> 
> > 56:   // on it.
> > 57:   if (FLAG_IS_DEFAULT(G1EagerReclaimRemSetThreshold)) {
> > 58:       guarantee(G1RSetSparseRegionEntries > 0, "");
> 
> please reduce "guarantee()" indentation and  consider not using an empty string

This has been a leftover debug code. I'll remove it, sorry.

-------------

PR: https://git.openjdk.java.net/jdk/pull/4248


[prev in list] [next in list] [prev in thread] [next in thread]