[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8267937: Wrong indentation in G1 gc+phases log for free cset subphases
From:       Albert Mingkun Yang <ayang () openjdk ! java ! net>
Date:       2021-05-28 15:12:06
Message-ID: Tx3RX-7yVg0NbtKdSNPMmmsCORztVe5EZUWtzOyW9kY=.9d94d1f5-476e-48c8-9bd4-fc1f41fe8ff5 () github ! com
[Download RAW message or body]

On Fri, 28 May 2021 13:59:37 GMT, Thomas Schatzl <tschatzl@openjdk.org> wrote:

> Hi all,
> 
> JDK-8214327: Join parallel phases post evacuation messed up some indentation of \
> logging: 
> The current gc+phases=trace looks as follows:
> ```
> [0.059s][debug][gc,phases   ] GC(1)       Redirty Logged Cards (ms):     Min:  0.0, \
> Avg:  0.0, Max:  0.0, Diff:  0.0, Sum:  0.0, Workers: 3 [0.059s][debug][gc,phases   \
> ] GC(1)         Redirtied Cards:               Min: 0, Avg: 184.3, Max: 531, Diff: \
> 531, Sum: 553, Workers: 3 [0.059s][debug][gc,phases   ] GC(1)       Free Collection \
> Set (ms):      Min:  0.0, Avg:  0.0, Max:  0.0, Diff:  0.0, Sum:  0.0, Workers: 3 \
> [0.059s][trace][gc,phases   ] GC(1)           Young Free Collection Set (ms): Min:  \
> 0.0, Avg:  0.0, Max:  0.0, Diff:  0.0, Sum:  0.0, Workers: 1 \
> [0.059s][trace][gc,phases   ] GC(1)           Non-Young Free Collection Set (ms): \
> skipped 
> `Young Free Collection Set` and `Non-Young Free Collection set` are indented one \
> level too many. 
> This change fixes this.
> 
> Testing: manual testing, there is no indentation check for log messages
> 
> Thanks,
> Thomas

Marked as reviewed by ayang (Committer).

-------------

PR: https://git.openjdk.java.net/jdk/pull/4249


[prev in list] [next in list] [prev in thread] [next in thread]