[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8267257: Shenandoah: Always deduplicate strings when it is enabled during full gc
From:       Roman Kennke <rkennke () openjdk ! java ! net>
Date:       2021-05-19 10:49:51
Message-ID: xRDPhFU8DW_IbZWnYskVbRKnWwc4ing4xbbWYKB9rNM=.1d92fe4b-9b71-454d-afec-f0a57fc84df0 () github ! com
[Download RAW message or body]

On Tue, 18 May 2021 15:18:32 GMT, Zhengyu Gu <zgu@openjdk.org> wrote:

> Full GC should recover as much memory as possible, so it should deduplicate all \
> string candidates regardless their ages, when it is enabled. Also enhanced \
> TestStringDedup.java test to ensure all candidates are deduplicated. 
> Note: Full GC does not preserve age bits, so current implementation will not \
> deduplicate any strings even with back-to-back full GCs. 
> Test:
> - [x] hotspot_gc_shenandoah

Looks good to me. Thank you!

-------------

Marked as reviewed by rkennke (Reviewer).

PR: https://git.openjdk.java.net/jdk/pull/4096


[prev in list] [next in list] [prev in thread] [next in thread]