[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8133805: Remove the bot_updates parameter from G1Allocator's allocation methods
From:       Thomas Schatzl <thomas.schatzl () oracle ! com>
Date:       2017-12-13 12:39:52
Message-ID: 1513168792.2560.1.camel () oracle ! com
[Download RAW message or body]

Hi,

On Tue, 2017-12-12 at 19:27 +0100, Leo Korinth wrote:
> Thanks for your reviews Thomas and Stefan!
> 
> > > - in g1AllocRegion.hpp, please fix the indentation of the
> > > parameters
> > > for G1AllocRegion::allocate() and par_allocate().
> > > 
> > > looks good otherwise.
> > 
> > I agree, align the parameters and this is good to go.
> > 
> 
> Oops, I have now fixed the indentation:
> 
> http://cr.openjdk.java.net/~lkorinth/8133805/00-01/
> http://cr.openjdk.java.net/~lkorinth/8133805/01/
> 

 ship it.

Thomas

[prev in list] [next in list] [prev in thread] [next in thread]