[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8189733: Cleanup Full GC setup and tear down
From:       Erik Helin <erik.helin () oracle ! com>
Date:       2017-11-22 18:18:26
Message-ID: a73bb9b5-5405-e2b8-35d8-34c50b0cb9af () oracle ! com
[Download RAW message or body]

On 11/22/2017 04:39 PM, Stefan Johansson wrote:
> Thanks Thomas for the review,
> 
> I got some comments from Erik and have updated the review accordingly. 
> Here are the new webrevs:
> Full: http://cr.openjdk.java.net/~sjohanss/8189733/01/
> Inc: http://cr.openjdk.java.net/~sjohanss/8189733/00-01/

Looks good, Reviewed. Nice cleanup!

Thanks,
Erik

> This change removes the heap() function as it's only used by member 
> functions which can use _heap. Also changed the initialization list to 
> use the parameters rather than the members initialized.
> 
> Thanks,
> Stefan
> 
> On 2017-11-16 09:31, Thomas Schatzl wrote:
>> Hi,
>>
>> On Wed, 2017-11-15 at 17:24 +0100, Stefan Johansson wrote:
>>> Hi,
>>>
>>> Please review this enhancement:
>>> https://bugs.openjdk.java.net/browse/JDK-8189733
>>>
>>> Webrev:
>>> http://cr.openjdk.java.net/~sjohanss//8189733/00/index.html
>>>
>>> Summary:
>>> After the G1FullCollector has been introduced as part of JEP 307 it
>>> makes sense to move more of the setup and tear down for the Full GC
>>> into
>>> this class. The G1FullGCScope is also moved into the G1FullCollector
>>> since it is now only used here.
>>      looks good.
>>
>> Thomas
>>
> 
[prev in list] [next in list] [prev in thread] [next in thread]