[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8182284: G1Analytics uses uninitialized fields
From:       Stefan Johansson <stefan.johansson () oracle ! com>
Date:       2017-11-21 10:07:15
Message-ID: aea5a827-2022-8bac-fb37-78d7dd982ac5 () oracle ! com
[Download RAW message or body]



On 2017-11-21 09:02, Erik Helin wrote:
> Hi all,
>
> this small patch just initializes two uninitialized fields in 
> G1Analytics. 0.0 is a good enough as starting value, the fields are 
> not meant to be read before a GC has been run (but if this would 
> happen, observing 0.0 fits together with the calculations that the 
> values represents).
>
> Bug:
> https://bugs.openjdk.java.net/browse/JDK-8182284
>
> Webrev:
> http://cr.openjdk.java.net/~ehelin/8182284/00/
>
Looks good,
Stefan
> Testing:
> - Mach5 hs-tier1,hs-tier2
> - Newly added unit test
>
> Thanks,
> Erik

[prev in list] [next in list] [prev in thread] [next in thread]