[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8189171: Move GC argument processing into GC specific classes
From:       Per Liden <per.liden () oracle ! com>
Date:       2017-10-26 9:43:53
Message-ID: affd801a-d184-1bcd-7c58-65c1ecaa94da () oracle ! com
[Download RAW message or body]

Hi,

On 2017-10-25 18:11, Erik Osterlund wrote:
[...]
>> So let me just put your changes up for review (again), if you don't mind:
>>
>> Full webrev:
>> http://cr.openjdk.java.net/~eosterlund/8189171/webrev.03/
>> <http://cr.openjdk.java.net/%7Eeosterlund/8189171/webrev.03/>

I like this. Just two naming suggestions:

src/hotspot/share/gc/shared/gcArguments.hpp:

   39   static jint create_instance();
   40   static bool is_initialized();
   41   static GCArguments* instance();

Could we call these:

   39   static jint initialize();
   40   static bool is_initialized();
   41   static GCArguments* arguments();

Reasoning: initialize() maps better to its companion is_initialized(). 
GCArguments::arguments() maps better to the existing patterns we have 
with CollectedHeap::heap().

cheers,
Per
[prev in list] [next in list] [prev in thread] [next in thread]