[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8166191: Missing spaces in log message
From:       sangheon <sangheon.kim () oracle ! com>
Date:       2017-04-11 17:28:10
Message-ID: 077feed4-27f9-4a3f-0ebe-1c8602a611ea () oracle ! com
[Download RAW message or body]

Hi Chihiro,

On 04/11/2017 07:02 AM, Thomas Schatzl wrote:
> Hi Chihiro,
>
> On Tue, 2017-04-11 at 03:04 +0900, chihiro ito wrote:
>> Hi all,
>>
>> Could I have a reviews for this fix, please? This patch add spaces
>> following each ":" like a JDK 8 log in log message.
>>
>> Log message that ran JDK 9 with -Xlog:gc+ergo+heap=debug option is
>> following.
>> [0.019s][debug][gc,ergo,heap] Expand the heap. requested expansion
>> amount: 10485760B expansion amount: 10485760B
>>
>> Log message that ran JDK 8 with -XX:+PrintAdaptiveSizePolicy option
>> is following.
>> 0.124: [G1Ergonomics (Heap Sizing) expand the heap, requested
>> expansion amount: 10485760 bytes, attempted expansion amount:
>> 10485760 bytes]
>>
>> Bug:
>> Missing spaces in log message
>> https://bugs.openjdk.java.net/browse/JDK-8166191
> I also noticed that just a few days ago. Thanks for fixing this :)
>
> I created a webrev from your diff at
>
> http://cr.openjdk.java.net/~tschatzl/8166191/webrev/
Looks good to me too. Thank you for the patch.

Thanks,
Sangheon


>
> Looks good. I can sponsor.
>
> Passes jprt.
>
> Thanks,
>    Thomas
>

[prev in list] [next in list] [prev in thread] [next in thread]