[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR: 8u40 backport of: 8062063: Usage of UseHugeTLBFS, UseLargePagesInMetaspace and huge Survivo
From:       Thomas Schatzl <thomas.schatzl () oracle ! com>
Date:       2015-01-14 11:22:21
Message-ID: 1421234541.3402.3.camel () oracle ! com
[Download RAW message or body]

Hi,

On Tue, 2015-01-13 at 17:02 +0100, Stefan Johansson wrote:
> Hi,
> 
> Please review this backport of JDK-8062063, it did not apply clean 
> because the code for AlwaysPreTouch is not backported to 8u40. Except 
> for these lines being absent the changeset for 8u40 is equal to the one 
> for 9:
> ---
>     if (AlwaysPreTouch) {
> -    os::pretouch_memory((char*)result.start(), (char*)result.end());
> +    os::pretouch_memory(page_start(start), page_start(end));
>     }
> ---
> 
> 8u40 changeset:
> http://cr.openjdk.java.net/~sjohanss/8068729/hotspot.00/hotspot.changeset
> 9 changeset:
> http://hg.openjdk.java.net/jdk9/hs-gc/hotspot/raw-rev/00e69efa02c6
> 
> Full 8u40 webrev:
> http://cr.openjdk.java.net/~sjohanss/8068729/hotspot.00


  looks good. Unfortunately this means we will have guaranteed merge
errors with the AlwaysPreTouch change...

Thanks,
  Thomas


[prev in list] [next in list] [prev in thread] [next in thread]