[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: RFR (L): 8064702: Remove the CMS foreground collector
From:       Bengt Rutisson <bengt.rutisson () oracle ! com>
Date:       2014-11-17 20:04:07
Message-ID: 546A54B7.2010508 () oracle ! com
[Download RAW message or body]

On 11/17/14 8:04 PM, Kim Barrett wrote:
> On Nov 17, 2014, at 4:38 AM, Bengt Rutisson <bengt.rutisson@oracle.com> wrote:
> > Ramki reviewed the change and noticed that the removed method \
> > decide_foreground_collection_type() method had a side effect that I had missed. \
> > It would set the _incremental_collection_failed state that is used for the sizing \
> > heuristics. Thanks for looking at this, Ramki!
> Good catch!
> 
> > Here's an updated webrev:
> > http://cr.openjdk.java.net/~brutisso/8064702/webrev.03/
> > 
> > Here's the diff compared to the last webrev:
> > http://cr.openjdk.java.net/~brutisso/8064702/webrev.02-03.diff/
> I looked it over again.  Looks good to me.

Thanks for looking at this again, Kim!

Bengt

> 
> 


[prev in list] [next in list] [prev in thread] [next in thread]