[prev in list] [next in list] [prev in thread] [next in thread] 

List:       openjdk-hotspot-gc-dev
Subject:    Re: Review request(7u): JDK-8010738: G1: Output for full GCs with +PrintGCDetails should contain per
From:       Poonam Bajaj <poonam.bajaj () oracle ! com>
Date:       2014-04-19 0:43:15
Message-ID: 5351C3D3.7000400 () oracle ! com
[Download RAW message or body]

Hi Thomas,

On 4/18/2014 6:45 PM, Thomas Schatzl wrote:
> HI,
>
> On Thu, 2014-04-17 at 06:33 +0530, Poonam Bajaj wrote:
>> Hi,
>>
>> Could I have reviews for the following fix:
>>
>> JDK-8010738: G1: Output for full GCs with +PrintGCDetails should
>> contain perm gen/meta data size change info
>> webrev: http://cr.openjdk.java.net/~poonam/8010738/webrev.00/
>>
>> With JDK7 G1GC when we use -XX:+PrintGCDetails option, PermGen
>> information does not get printed in the Full GC logs as shown below:
>> [Full GC 16M->16M(20M), 0.7055536 secs]
>>     [Eden: 0.0B(1024.0K)->0.0B(1024.0K) Survivors: 0.0B->0.0B Heap:
>> 16.7M(20.0M)->16.7M(20.0M)]
>>
>> PermGen info should also get printed with Full GC info similar to what
>> other garbage collectors report. These changes are backport of the fix
>> in jdk8 where MetaSpace info gets printed in the Full GC logs.
>>
>> With the fix the output looks like:
>> [Full GC 16M->16M(20M), 0.6763478 secs]
>>     [Eden: 0.0B(1024.0K)->0.0B(1024.0K) Survivors: 0.0B->0.0B Heap:
>> 16.7M(20.0M)->16.7M(20.0M)], [Perm: 1725K->1725K(16384K)]
>>
>    just out of curiosity, do the other collectors also add a comma
> between the output for the heap proper and the perm gen statistics?
Yes, e.g.

[Full GC (System) [Tenured: 0K->290K(4480K), 0.0053810 secs] 
694K->290K(6464K), [Perm : 2625K->2625K(21248K)], 0.0058610 secs] 
[Times: user=0.01 sys=0.00, real=0.01 secs]

Thanks,
Poonam

> Thanks,
>    Thomas
>
>
[prev in list] [next in list] [prev in thread] [next in thread]